Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. #6625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dwijnand (rust_highfive has picked a reviewer for you, use r? to override) |
|
I think we should consider backporting to beta since this is a regression from stable. |
ehuss
force-pushed
the
fix-macos-fallback-path
branch
from
2697783
to
e1d0761
Compare
|
@bors: r+ Sounds good to me! A backport to beta also sound good to me |
|
📌 Commit e1d0761 has been approved by |
|
⌛ Testing commit e1d0761 with merge f18c9d56c6e8551c3e519261ed0a3994000eace0... |
|
💔 Test failed - checks-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 4, 2019
Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. On MacOS, dyld uses the default `$(HOME)/lib:/usr/local/lib:/lib:/usr/lib` for `DYLD_FALLBACK_LIBRARY_PATH` when it is not set. #6355 switched cargo to use `DYLD_FALLBACK_LIBRARY_PATH`, which means the default paths no longer worked. This explicitly adds the defaults back to the end of the list. Fixes #6623
|
☀️ Test successful - checks-travis, status-appveyor |
|
So fast! Thanks everyone!! |
bors
added a commit
that referenced
this pull request
Feb 4, 2019
[BETA] Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. Backport of #6625.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 10, 2019
Bump cargo to 865cb70 Merged PRs: * Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620 * keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611 * Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625 * Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628 * In cargo test's help, add that examples are built rust-lang/cargo#6619 * Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621 * Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630 * Fix run's help message rust-lang/cargo#6631 * Some updates to bash completion. rust-lang/cargo#6644 * Introduce Source::download_now rust-lang/cargo#6637 * Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Feb 11, 2019
Bump cargo to 865cb70 Merged PRs: * Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620 * keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611 * Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625 * Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628 * In cargo test's help, add that examples are built rust-lang/cargo#6619 * Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621 * Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630 * Fix run's help message rust-lang/cargo#6631 * Some updates to bash completion. rust-lang/cargo#6644 * Introduce Source::download_now rust-lang/cargo#6637 * Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
glandium
added a commit
to glandium/rustup.rs
that referenced
this pull request
Apr 16, 2019
When loading and linking a dynamic library or bundle, dlopen searches in LD_LIBRARY_PATH, DYLD_LIBRARY_PATH, PWD, and DYLD_FALLBACK_LIBRARY_PATH. In the Mach-O format, a dynamic library has an "install path." Clients linking against the library record this path, and the dynamic linker, dyld, uses it to locate the library. dyld searches DYLD_LIBRARY_PATH *before* the install path. dyld searches DYLD_FALLBACK_LIBRARY_PATH only if it cannot find the library in the install path. Setting DYLD_LIBRARY_PATH can easily have unintended consequences. See https://users.rust-lang.org/t/subprocess-and-dynamic-library-linking-problem-interaction/7873/10 See https://trac.macports.org/ticket/57692 See https://bugzilla.mozilla.org/show_bug.cgi?id=1536486 This is the same change as was applied to cargo in rust-lang/cargo#6355 See also rust-lang/cargo#6625 and rust-lang/cargo#6625
|
This is still an issue because Cargo is setting EDIT: Ignore me, it's not cargo but something else, it seems. Sent with GitHawk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, dyld uses the default
$(HOME)/lib:/usr/local/lib:/lib:/usr/libforDYLD_FALLBACK_LIBRARY_PATHwhen it is not set. #6355 switched cargo to useDYLD_FALLBACK_LIBRARY_PATH, which means the default paths no longer worked. This explicitly adds the defaults back to the end of the list.Fixes #6623